Ethernet wiring fixes #6534
Merged
Ethernet wiring fixes #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TX<->RX should only be swapped when connecting two ethernet devices directly. When a switch is used TX and RX should not be swapped
TX<->RX should only be swapped when connecting two ethernet devices directly. When a switch is used TX and RX should not be swapped
|
we can discuss....not sure about the siyi...I think I had issues....because the SIYI mac did not have autoMDIX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Ethernet Connectivity section wiring diagrams for the Siyi and Topotek gimbal pages.
The original diagrams were added as part of #6479 and #6517
The original wiring worked but I now understand that the swapping of TX/RX pins is only required when we are directly connecting two devices. When all the devices are connected via an Ethernet switch (as they are in the two diagrams) then we should not swap TX and RX.
I've re-tested the Topotek with the corrected wiring and it works fine. I haven't tested the Siyi wiring but from inspection I think it should be fine
I've build these changes locally and they look OK to me
BTW, I think this means we should also update the ethernet-vehicle page's house-of-babel section