Chore: java 17 and general cleanup

[robfrank]

What does this PR do?

Refactor to use more java 17 idioms
Replace most of i prefixed parameters

yes, it's huge, but it contains just cosmetic changes

Motivation

Evolve the code to be ready when we can migrate to java 21

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +2.49%	✅ 52.49%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (f086acb)	68195	43771	64.19%
Head commit (213feea)	64524 (-3671)	43020 (-751)	66.67% (+2.49%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1916)	2827	1484	52.49%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}