#1763 fix createEdgeStep and reinforce tests (#1918)

ArcadeData · Jan 15, 2025 · 8f25690 · 8f25690
1 parent f086acb
commit 8f25690
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/engine/src/main/java/com/arcadedb/query/sql/executor/CreateEdgesStep.java b/engine/src/main/java/com/arcadedb/query/sql/executor/CreateEdgesStep.java
@@ -127,7 +127,7 @@ public Result next(final Object[] properties) {
               for (Edge existingEdge : context.getDatabase().getGraphEngine()
                   .getEdges((VertexInternal) currentFrom, Vertex.DIRECTION.OUT, targetClass.getStringValue())) {
 
-                if (existingEdge.getOut().equals(currentTo)) {
+                if (existingEdge.getIn().equals(currentTo)) {
                   currentTo = null;
                   currentBatch++;
                   return new UpdatableResult(existingEdge.modify());

diff --git a/engine/src/test/java/com/arcadedb/graph/BasicGraphTest.java b/engine/src/test/java/com/arcadedb/graph/BasicGraphTest.java
@@ -673,14 +673,7 @@ public void edgeUnivocitySQL() {
       // EXPECTED
     }
 
-    try {
-      database.transaction(
-          () -> database.command("sql", "create edge OnlyOneBetweenVertices from ? to ? IF NOT EXISTS", v1[0], v2[0]));
-      fail("");
-    } catch (final DuplicatedKeyException ex) {
-      // EXPECTED
-    }
-
+    database.transaction(() -> database.command("sql", "create edge OnlyOneBetweenVertices from ? to ? IF NOT EXISTS", v1[0], v2[0]));
   }
 
   @Test

diff --git a/engine/src/test/java/com/arcadedb/query/sql/executor/CreateEdgeStatementExecutionTest.java b/engine/src/test/java/com/arcadedb/query/sql/executor/CreateEdgeStatementExecutionTest.java
@@ -112,12 +112,6 @@ void createEdgeIfNotExists() {
           """);
     });
 
-    database.transaction(() -> {
-      final ResultSet rs = database.query("SQL", """
-          select from vex
-          """);
-      assertThat(rs.stream().count()).isEqualTo(3);
-    });
     // CREATE EDGES FROM #1:0 TO [#1:1,#1:2]
     database.transaction(() -> {
       final ResultSet rs = database.command("sql", """
@@ -131,18 +125,31 @@ void createEdgeIfNotExists() {
       final ResultSet rs = database.command("sql", """
           CREATE EDGE edg FROM #1:0 TO [#1:1,#1:2] IF NOT EXISTS
           """);
-      assertThat(rs.hasNext()).isTrue();
       assertThat(rs.stream().count()).isEqualTo(2);
     });
-
+    // CHECK THAT TOTAL  EDGES ARE STILL 2
+    database.transaction(() -> {
+      final ResultSet rs = database.query("SQL", """
+          select from edg
+          """);
+      assertThat(rs.stream().count()).isEqualTo(2);
+    });
     // CREATE AGAIN (should create 1 edge)
     database.transaction(() -> {
       final ResultSet rs = database.command("sql", """
           CREATE EDGE edg FROM #1:0 TO [#1:1,#1:2,#1:0] IF NOT EXISTS
           """);
-      assertThat(rs.hasNext()).isTrue();
       assertThat(rs.stream().count()).isEqualTo(3);
     });
 
+    // CHECK THAT TOTAL  EDGES ARE STILL 3
+    database.transaction(() -> {
+      final ResultSet rs = database.query("SQL", """
+          select from edg
+          """);
+      assertThat(rs.stream().count()).isEqualTo(3);
+    });
+
+
   }
 }