-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Control construct and re-engineer closure conversion #138
Draft
Hugobros3
wants to merge
201
commits into
development
Choose a base branch
from
control
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many methods in the LLVM back-end assume a continuation as one of the operands of calls to intrinsics. This is inflexible and brittle - this commit instead have the intrinsics yield LLVM values directly (see `emit_intrinsic`), and then `emit_epilogue` is made responsible for forwarding those values alongside control-flow. To help in this, we extract a new `emit_call` method: this method is in charge of "making calls", with supplied LLVM values. What is being called can vary: it can be a basic block, a direct-style function, a return parameter, a closure etc ... `emit_epilogue` works in concert with `emit_call` and is in charge of calling it a second time for direct-style calls, for forwarding the argumnents. Finally, `emit_epilogue` might need to terminate the basic block if it otherwise ends in a function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 🚧 draft 🚧 PR adds a
control
construct as found in Shady and performs a significant amount of refactoring on the IR to support closure conversion more robustly. This is not currently merge-able and exists as a tracking issue.Current changelist:
control
intrinsic and matchingJoinPointType
ReturnType
type that encodes the codomain of a function.Rewriter
World::scoped_dump
that uses the new scope analysis to pretty-print IRThe lowering for this is tricky: setjmp/longjmp cannot be safely used inside functions because they can overwrite side effects that have happened in-between the
control
call and consuming the token. One solution is to emit cps-style code instead of direct-style, and then we can use tailcalls and perform manual stack pointer adjustments instead.However there are backends where this will not be permissible (those who lack true function calls mostly) and we will need to find an alternative solution for those.
Still TODO: