Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Immediately close on bad block #912

Merged
merged 3 commits into from
Oct 9, 2024
Merged

P2P: Immediately close on bad block #912

merged 3 commits into from
Oct 9, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 8, 2024 •
edited
Loading

Note almost all the work of #643 was done as part of #529. This PR represents the remaining part of closing immediately if a block is invalid.

Resolves #643
Resolves #804

@heifner heifner requested review from linh2931 and greg7mdp October 8, 2024 20:53
@heifner heifner added the OCI Work exclusive to OCI team label Oct 8, 2024
@heifner heifner merged commit aeac29e into main Oct 9, 2024
36 checks passed
@heifner heifner deleted the GH-643-unlinkable branch October 9, 2024 12:43
@heifner heifner mentioned this pull request Oct 9, 2024
Closed
@ericpassmore ericpassmore added the enhancement New feature or request label Oct 15, 2024
@ericpassmore
Copy link
Contributor

Note:start
category: System Stability
component: P2P
summary: With the exception of unlinkable blocks, disconnect immediately instead of allowing for 13 invalid blocks before disconnect.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
4 participants
@heifner @ericpassmore @greg7mdp @linh2931