Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Avoid using fork in log messages that are not about micro-forks #75

Merged
merged 1 commit into from
Apr 26, 2024
Merged

IF: Avoid using fork in log messages that are not about micro-forks #75

merged 1 commit into from
Apr 26, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 26, 2024

Use of fork in log messages in net_plugin caused confusion as they are not indicating micro-forking.

Resolves #73

@heifner heifner requested review from greg7mdp and linh2931 April 26, 2024 12:58
@heifner heifner added the OCI Work exclusive to OCI team label Apr 26, 2024
@heifner heifner linked an issue Apr 26, 2024 that may be closed by this pull request
Change Net Plugin Log Messages To Be Less Alarming #73
Closed
@heifner heifner merged commit 66f3c3a into savanna Apr 26, 2024
36 checks passed
@heifner heifner deleted the GH-73-net-logs branch April 26, 2024 13:59
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Avoid using fork in log messages that are not related to micro-forks.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Net Plugin Log Messages To Be Less Alarming
4 participants
@heifner @ericpassmore @greg7mdp @linh2931