spring rebrand

[spoonincode]

Renames almost all occurrences of leap/Leap to spring/Spring. Originally I was planning on only renaming "user facing" usages of leap, but it turns out it's easier to just be more exhaustive instead of trying to make a case-by-case basis judgement call.

CONTRIBUTING.md has been removed; it will be rewritten entirely at some point anyways.

Taking a grep through the repo here are the remaining usages of leap I see,

legacy cmake files

This allows users of libtester to continue finding it via find_package(leap) etc.

spring/CMakeLists.txt

Lines 201 to 204 in 7a5a807

	# legacy leap CMake files
	configure_file(${CMAKE_SOURCE_DIR}/CMakeModules/leap-config.cmake.in ${CMAKE_BINARY_DIR}/lib/cmake/leap/leap-config.cmake @ONLY)
	configure_file(${CMAKE_SOURCE_DIR}/CMakeModules/EosioTesterBuild.cmake.in ${CMAKE_BINARY_DIR}/lib/cmake/leap/EosioTester.cmake @ONLY)
	configure_file(${CMAKE_SOURCE_DIR}/CMakeModules/EosioCheckVersion.cmake ${CMAKE_BINARY_DIR}/lib/cmake/leap/EosioCheckVersion.cmake COPYONLY)

spring/CMakeLists.txt

Lines 217 to 221 in 7a5a807

	# legacy leap CMake files
	configure_file(${CMAKE_SOURCE_DIR}/CMakeModules/leap-config.cmake.in ${CMAKE_BINARY_DIR}/modules/leap-config.cmake @ONLY)
	install(FILES ${CMAKE_BINARY_DIR}/modules/leap-config.cmake DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}/cmake/leap COMPONENT dev EXCLUDE_FROM_ALL)
	install(FILES ${CMAKE_BINARY_DIR}/modules/EosioTester.cmake DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}/cmake/leap COMPONENT dev EXCLUDE_FROM_ALL)
	install(FILES ${CMAKE_SOURCE_DIR}/CMakeModules/EosioCheckVersion.cmake DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR}/cmake/leap COMPONENT dev EXCLUDE_FROM_ALL)

spring/CMakeModules/leap-config.cmake.in

Lines 1 to 3 in 7a5a807

	list(APPEND CMAKE_MODULE_PATH @EOS_ROOT_DIR@/cmake/leap)
	include(EosioTester)
	include(EosioCheckVersion)

package conflicts

This allows installing spring.deb "over" a leap.deb

spring/package.cmake

Lines 50 to 51 in 7a5a807

	set(CPACK_DEBIAN_PACKAGE_CONFLICTS "eosio, mandel, leap")
	set(CPACK_RPM_PACKAGE_CONFLICTS "eosio, mandel, leap")

libtester tests

These are currently using main of reference-contracts which does the find_package(leap) as well as having a cmake knob with LEAP in the name. Eventually we will change this to a find_package(spring) etc and we'll need to update this.

spring/.github/workflows/build.yaml

Lines 288 to 290 in 7a5a807

	name: Set leap_DIR env var
	run: |
	echo "leap_DIR=$PWD/build/lib/cmake/leap" >> "$GITHUB_ENV"

spring/.github/workflows/build.yaml

Line 339 in 7a5a807

cmake -S reference-contracts -B reference-contracts/build -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTS=On -DSYSTEM_ENABLE_LEAP_VERSION_CHECK=Off -DSYSTEM_ENABLE_CDT_VERSION_CHECK=Off

performance harness runner

This is just a label for a configured runner that has already been attached to this repo too

spring/.github/workflows/performance_harness_run.yaml

Line 109 in 7a5a807

runs-on: ["Leap-Perf-Ubuntu-22-16x64x600"]

performance harness backwards compatibility

Clearly this should still download the old version of leap from the old repo. (This is looking outdated already due to the lack of 5.0 support though?)

spring/.github/workflows/ph_backward_compatibility.yaml

Lines 57 to 67 in 7a5a807

	- name: Download Prev Leap Version
	uses: AntelopeIO/asset-artifact-download-action@v3
	with:
	owner: AntelopeIO
	repo: leap
	file: '(leap).*${{matrix.platform}}.04.*(x86_64|amd64).deb'
	target: '${{matrix.release}}'
	- name: Install leap & replace binaries for PH use
	run: |
	apt-get update
	apt-get install -y ./leap*.deb

experimental-binaries container description

The experimental-binaries container name is currently shared by both leap & spring. We might want to change this though as there will be a version conflict. Tracked in #50

spring/.github/workflows/release.yaml

Line 38 in 7a5a807

LABEL org.opencontainers.image.description="A collection of experimental Leap and Spring binary packages"

some docs

Clarify leap 4/5 is before spring 1.0

spring/docs/01_nodeos/03_plugins/producer_plugin/10_block-producing-explained.md

Lines 39 to 41 in 7a5a807

	Starting in Leap 4.0 (a predecessor of Spring 1.0), blocks are propagated after block header validation. This means instead of `BP-A Peer` & `BP-B Peer` taking `m` time to validate and forward a block it only takes a small number of milliseconds to verify the block header and then forward the block.
	Starting in Leap 5.0 (a predecessor of Spring 1.0), blocks in a round are started immediately after the completion of the previous block. Before 5.0, blocks were always started on `w` intervals and a node would "sleep" between blocks if needed. In 5.0, the "sleeps" are all moved to the end of the block production round.

net_plugin naming

It feels like usages of "leap" here are referencing a point in time so I think we want to keep the naming

spring/plugins/net_plugin/net_plugin.cpp

Line 664 in 7a5a807

constexpr uint16_t proto_leap_initial = 7; // leap client, needed because none of the 2.1 versions are supported

spring/plugins/net_plugin/net_plugin.cpp

Line 668 in 7a5a807

constexpr uint16_t net_version_max = proto_leap_initial;

spring/plugins/net_plugin/net_plugin.cpp

Lines 3405 to 3406 in 7a5a807

	// we don't support the 2.1 packed_transaction & signed_block, so tell 2.1 clients we are 2.0
	if( protocol_version >= proto_pruned_types && protocol_version < proto_leap_initial ) {

spring/plugins/net_plugin/net_plugin.cpp

Line 3459 in 7a5a807

// some clients before leap 5.0 provided microsecond epoch instead of nanosecond epoch

CLI11 leap formatter

This LeapFormatter exists over in the separate CLI11 submodule.. I didn't want to change that for now (or maybe ever).

spring/programs/cleos/main.cpp

Lines 2786 to 2787 in 7a5a807

	// custom leap formatter
	auto fmt = std::make_shared<CLI::LeapFormatter>();

spring/programs/spring-util/main.cpp

Lines 20 to 21 in 7a5a807

	// custom leap formatter
	auto fmt = std::make_shared<CLI::LeapFormatter>();

comment referencing leap issue

This one is self explanatory

spring/tests/nodeos_run_test.py

Line 751 in 7a5a807

# the resulting exception in http-plugin is caught and doesn't cause nodeos to crash (leap issue #1372).

[spoonincode]

These links don't work currently

[spoonincode]

I'm not sure what else to do here at the moment. Tracking in #49

[heifner]

We should probably ask EOS Nation if this should be spring 1 0 instead. Ok, for now.

[spoonincode]

one way or another we should probably touch the version number before release since new messages are being added I think? It seems even in savanna branch the version remains 13 0

[heifner]

Yes, this #29 needs to change that version. I'll make the change there.

[ericpassmore]

Note:start
group: IF
category: CHORE
summary: Rebrand to Spring.
Note:end