Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Increase checktime test timeouts #271

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 11, 2024

The checktime tests provide a useful indication of timeouts working correctly. However, they rely on wall clock time which can vary on ci/cd machines with many tests running concurrently. Tweak timeouts to allow more time for tests to complete.

Resolves #65

@heifner heifner requested review from linh2931 and greg7mdp June 11, 2024 15:22
@heifner heifner added the OCI Work exclusive to OCI team label Jun 11, 2024
@heifner heifner linked an issue Jun 11, 2024 that may be closed by this pull request
Base automatically changed from GH-235-test to main June 11, 2024 16:03
@spoonincode
Copy link
Member

wrong issue linked?

@heifner
Copy link
Member Author

heifner commented Jun 11, 2024

wrong issue linked?

Thanks. Fixed.

Copy link
Member

@spoonincode spoonincode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay from what I can tell

@heifner heifner merged commit 1570bf7 into main Jun 11, 2024
68 of 71 checks passed
@heifner heifner deleted the GH-65-test-checktime branch June 11, 2024 16:29
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Increase settings in checktime test.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Failure: checktime_pause_block_deadline_not_extended_while_loading_test
5 participants