-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update finalizer safety info file based on received QC #247
Conversation
Note:start |
Some more thoughts:
|
I don't think we should do 1. We still want to handle the case where nodeos is using an old finalizer safety information file. I do think we should do 2, after we have implemented the changes of #259. |
Note:start |
If a node deletes their finalizer safety information file, they may lose critical safety information such as the block they should be locked on. But in some cases, this information can be recovered based on the evidence in the QCs attached to blocks that the node receives from peers.
When processing a QC in a block, node checks to see if any of the finalizer keys it manages are represented in the QC as a strong vote. If that block is more recent than the current lock in the finalizer safety information file for that finalizer key, then update the lock.
Resolves #135