Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0-beta1] Vote processing fix #158

Merged
merged 3 commits into from
May 17, 2024
Merged

[1.0-beta1] Vote processing fix #158

merged 3 commits into from
May 17, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented May 17, 2024 •
edited
Loading

  • Do not post to vote thread pool if thread pool is not active.
    • This fixes a memory leak when there are no vote threads; which is why this PR is targeted to 1.0-beta1 instead of main
  • A producer should notify vote processor that it has produced a block
  • Update the tester wait on votes to be consistent

Resolves #139
Resolves #143

@heifner heifner linked an issue May 17, 2024 that may be closed by this pull request
Test Failure: svnn_ibc_unit_test_eos-vm-jit #139
Closed
@heifner heifner requested review from linh2931 and spoonincode May 17, 2024 16:15
@heifner heifner added the OCI Work exclusive to OCI team label May 17, 2024
@arhag arhag linked an issue May 17, 2024 that may be closed by this pull request
Test Failure: finality_unit_test_eos-vm-jit #143
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: BUG
summary: Do not post to vote thread pool if thread pool is not active.
Note:end

linh2931
linh2931 approved these changes May 17, 2024
View reviewed changes
libraries/testing/tester.cpp
@@ -499,7 +499,7 @@ namespace eosio::testing {
// wait for this node's vote to be processed
size_t retrys = 200;
while (!c.node_has_voted_if_finalizer(c.head_block_id()) && --retrys) {
std::this_thread::sleep_for(std::chrono::milliseconds(10));
std::this_thread::sleep_for(std::chrono::milliseconds(5));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if retries and the sleep time are defined as constants so that they can be kept consistent in the future. But you don't need to make this change for now.

@heifner heifner merged commit 016f190 into release/1.0-beta1 May 17, 2024
36 checks passed
@heifner heifner deleted the GH-139-vote-not-received-beta1 branch May 17, 2024 18:20
@heifner heifner mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@spoonincode spoonincode spoonincode approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Failure: finality_unit_test_eos-vm-jit Test Failure: svnn_ibc_unit_test_eos-vm-jit
4 participants
@heifner @ericpassmore @spoonincode @linh2931