Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposed finalizer policy to SHiP finality_data stream #124

Merged
merged 9 commits into from
May 10, 2024
Merged

Add proposed finalizer policy to SHiP finality_data stream #124

merged 9 commits into from
May 10, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented May 9, 2024

Add proposed finalizer policy to SHiP finality_data stream

Resolves #123

@linh2931 linh2931 requested review from heifner and greg7mdp May 9, 2024 00:16
greg7mdp
greg7mdp requested changes May 9, 2024
View reviewed changes
libraries/chain/include/eosio/chain/block_state.hpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp previously approved these changes May 9, 2024
View reviewed changes
@linh2931 linh2931 requested a review from heifner May 10, 2024 14:09
@linh2931 linh2931 requested a review from greg7mdp May 10, 2024 14:14
@greg7mdp greg7mdp dismissed their stale review May 10, 2024 14:44

changes

@linh2931 linh2931 requested a review from greg7mdp May 10, 2024 20:49
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Extend finality data to include full policy (including generation number) of the finalizer policy proposed in the associated block. This is used in SHiP data stream.
Note:end

@linh2931 linh2931 merged commit 45d9c8e into main May 10, 2024
36 checks passed
@linh2931 linh2931 deleted the finalizer_policies_in_finality_data branch May 10, 2024 21:33
@greg7mdp greg7mdp mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add proposed finalizer policy to SHiP finality_data stream
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner