Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a couple different signedness comparison warnings #122

Merged
merged 1 commit into from
May 8, 2024
Merged

fix a couple different signedness comparison warnings #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/testing/include/eosio/testing/tester.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ namespace eosio::testing {
const auto& fin_policy = ext.new_finalizer_policy;
BOOST_TEST(!!fin_policy);
BOOST_TEST(fin_policy->finalizers.size() == fin_policy_size);
BOOST_TEST(fin_policy->generation == 1);
BOOST_TEST(fin_policy->generation == 1u);
BOOST_TEST(fin_policy->threshold == (fin_policy_size * 2) / 3 + 1);

// wait till the genesis_block becomes irreversible.
Expand Down
4 changes: 2 additions & 2 deletions unittests/svnn_ibc_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ BOOST_AUTO_TEST_SUITE(svnn_ibc)
auto genesis_block = cluster.produce_and_push_block();

// ensure out of scope setup and initial cluster wiring is consistent
BOOST_CHECK_EQUAL(genesis_block->block_num(), 4);
BOOST_CHECK_EQUAL(genesis_block->block_num(), 4u);

// check if IF Genesis block contains an IF extension
std::optional<eosio::chain::block_header_extension> maybe_genesis_if_ext =
Expand All @@ -105,7 +105,7 @@ BOOST_AUTO_TEST_SUITE(svnn_ibc)
eosio::chain::finalizer_policy active_finalizer_policy = maybe_active_finalizer_policy.value();

BOOST_CHECK_EQUAL(active_finalizer_policy.finalizers.size(), cluster.num_nodes);
BOOST_CHECK_EQUAL(active_finalizer_policy.generation, 1);
BOOST_CHECK_EQUAL(active_finalizer_policy.generation, 1u);

// compute the digest of the finalizer policy
auto active_finalizer_policy_digest = fc::sha256::hash(active_finalizer_policy);
Expand Down
Loading