Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finalizer safety information file based on vote evidence from received blocks #135

Closed
arhag opened this issue May 13, 2024 · 0 comments · Fixed by #247
Closed

Update finalizer safety information file based on vote evidence from received blocks #135

arhag opened this issue May 13, 2024 · 0 comments · Fixed by #247
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone

Comments

@arhag
Copy link
Member

arhag commented May 13, 2024

Depends on #259.

If a node deletes their finalizer safety information file, they may lose critical safety information such as the block they should be locked on. But in some cases, this information can be recovered based on the evidence in the QCs attached to blocks that the node receives from peers.

When processing a QC in a block, the node can check to see if any of the finalizer keys it manages are represented in the QC as a strong vote. If so, it can determine (by looking at the history of QC claims within that branch, which is stored in the finality_core) which block (ID and timestamp) the node should have been locked on due to casting that strong vote. If that block is more recent than the current lock in the finalizer safety information file for that finalizer key, then the lock should be updated.

@arhag arhag added this to the Savanna: Cusp milestone May 13, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 13, 2024
@arhag arhag added 👍 lgtm and removed triage labels May 13, 2024
@heifner heifner self-assigned this May 20, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog May 20, 2024
@heifner heifner added the OCI Work exclusive to OCI team label May 20, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Todo in Team Backlog May 21, 2024
@heifner heifner self-assigned this Jun 6, 2024
heifner added a commit that referenced this issue Jun 6, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Jun 6, 2024
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jun 10, 2024
heifner added a commit that referenced this issue Jun 11, 2024
Update finalizer safety info file based on received QC
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants