Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposed finalizer policy to SHiP finality_data stream #123

Closed
arhag opened this issue May 8, 2024 · 0 comments · Fixed by #124
Closed

Add proposed finalizer policy to SHiP finality_data stream #123

arhag opened this issue May 8, 2024 · 0 comments · Fixed by #124
Assignees

Comments

@arhag
Copy link
Member

arhag commented May 8, 2024

The finality_data should have a new optional field to contain the full policy (including generation number) of the finalizer policy proposed in the associated block. If no new finalizer policy is proposed in a block, then this field should be std::nullopt. The SHiP logs will have to contain this additional field.

@arhag arhag added this to the Savanna: Production-Ready milestone May 8, 2024
@arhag arhag added the 👍 lgtm label May 8, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 8, 2024
@arhag arhag removed the triage label May 8, 2024
@linh2931 linh2931 moved this from Todo to Awaiting Review in Team Backlog May 9, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants