Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arcadia fix val #22

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Arcadia fix val #22

merged 5 commits into from
Dec 19, 2024

Conversation

bianyuanop
Copy link

@bianyuanop bianyuanop commented Dec 18, 2024 •
edited
Loading

This PR should be reviewed /w AnomalyFi/nodekit-seq#28

  • val server port derive from nodeID or use from specified
  • move StartEpoch to RollupInfo
  • add ExitEpoch to RollupInfo
  • guards on registration & exit so rollup info at epoch n+1 remain untouched

manojkgorle
manojkgorle reviewed Dec 18, 2024
View reviewed changes
arcadia/arcadia.go Outdated Show resolved Hide resolved
manojkgorle
manojkgorle reviewed Dec 18, 2024
View reviewed changes
arcadia/registry.go Outdated Show resolved Hide resolved
@bianyuanop bianyuanop merged commit 20deada into arcadia Dec 19, 2024
1 of 7 checks passed
@bianyuanop bianyuanop deleted the arcadia-fix-val branch December 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojkgorle manojkgorle manojkgorle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bianyuanop @manojkgorle