fix(editor): do not proceed in saveResult() if editor.save() fails (f…

…ixes #1463)
AndroidIDEOfficial · Nov 13, 2023 · 93bb303 · 93bb303
1 parent 6f590a3
commit 93bb303
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/app/src/main/java/com/itsaky/androidide/activities/editor/EditorHandlerActivity.kt b/app/src/main/java/com/itsaky/androidide/activities/editor/EditorHandlerActivity.kt
@@ -427,17 +427,16 @@ open class EditorHandlerActivity : ProjectHandlerActivity(), IEditorHandler {
     }
 
     val frag = getEditorAtIndex(index) ?: return
-    if (frag.file == null) {
-      return
-    }
+    val fileName = frag.file?.name ?: return
 
     run {
       // Must be called before frag.save()
       // Otherwise, it'll always return false
       val modified = frag.isModified
-      frag.save()
+      if (!frag.save()) {
+        return
+      }
 
-      val fileName = frag.file!!.name
       val isGradle = fileName.endsWith(".gradle") || fileName.endsWith(".gradle.kts")
       val isXml: Boolean = fileName.endsWith(".xml")
       if (!result.gradleSaved) {