fix(preferences): validate initial selection index in SingleChoicePre…

…ference
AndroidIDEOfficial · Nov 11, 2023 · 8eddcc2 · 8eddcc2
1 parent b140829
commit 8eddcc2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/preferences/src/main/java/com/itsaky/androidide/preferences/SingleChoicePreference.kt b/preferences/src/main/java/com/itsaky/androidide/preferences/SingleChoicePreference.kt
@@ -20,6 +20,7 @@ package com.itsaky.androidide.preferences
 import android.content.Context
 import androidx.preference.Preference
 import com.google.android.material.dialog.MaterialAlertDialogBuilder
+import java.lang.IndexOutOfBoundsException
 
 /**
  * A preference which allows selecting a single value from a list of values.
@@ -56,6 +57,9 @@ abstract class SingleChoicePreference : ChoiceBasedDialogPreference(), Preferenc
   ) {
 
     this.currentSelection = getInitiallySelectionItemPosition(preference.context)
+    if (currentSelection < 0 || currentSelection >= choices.size) {
+      throw IndexOutOfBoundsException("Initial selection: $currentSelection, size=${choices.size}")
+    }
 
     dialog.setSingleChoiceItems(
       choices,