Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ayab-esp32 Build environment #182

Closed
wants to merge 12 commits into from
Closed

Add ayab-esp32 Build environment #182

wants to merge 12 commits into from

Conversation

dl1com
Copy link
Contributor

@dl1com dl1com commented Jan 22, 2024

This Pull Request adds support to communicate with the new ayab-esp32 hardware platform.
Functionality is the same as with Arduino Uno

Still To Do:

  • Fill in the pin numbers for the ayab-esp32 board in board.h
  • Implemented board definition file
  • Add code to support using comparator EOL markers.
  • Implement MCP23017 support
  • Test on Hardware

Copy link

github-actions bot commented Feb 1, 2024

Test Results

104 tests  ±0   104 ✅ ±0   0s ⏱️ ±0s
104 suites ±0     0 💤 ±0 
104 files   ±0     0 ❌ ±0 

Results for commit 4eb13fe. ± Comparison against base commit c6c1b2a.

♻️ This comment has been updated with latest results.

@VIPQualityPost
Copy link

VIPQualityPost commented Feb 2, 2024

New Adafruit MCP23017 library has support for both MCP23017 and MCP23008. I did not lock the version but we can do this if necessary. Removed git submodules.

@VIPQualityPost
Copy link

I think we should merge this as-is. The PR is for build environment which I think is good to go.
After this: one PR for refactor EOL code to support analog + comparator, and another for cleaning up pin names/ hardware interfaces.

@dl1com dl1com marked this pull request as ready for review February 5, 2024 19:48
platformio.ini Outdated Show resolved Hide resolved
src/ayab/board.h Outdated Show resolved Hide resolved
@dl1com
Copy link
Contributor Author

dl1com commented Feb 5, 2024

Seems the CI still sees the .gitmodules file although it has been deleted. Let's give it a try and merge, worst case we have to fix it after merge... :-/

@dl1com dl1com requested a review from t0mpr1c3 February 5, 2024 20:04
@dl1com
Copy link
Contributor Author

dl1com commented Feb 5, 2024

@t0mpr1c3 could you please review the PR so we can merge? I can't as I am an author to this PR as well.

@t0mpr1c3
Copy link
Contributor

@t0mpr1c3 could you please review the PR so we can merge? I can't as I am an author to this PR as well.

Yes, just let me know when the dependencies are sorted out.

@VIPQualityPost
Copy link

I think the dependencies were all sorted out- just an issue with CI for now which might require bringing the PR in anyway so that the CI is not looking for old files.

@dl1com
Copy link
Contributor Author

dl1com commented Feb 26, 2024

I think the dependencies were all sorted out- just an issue with CI for now which might require bringing the PR in anyway so that the CI is not looking for old files.

Yes...so I think we can merge this one for now to see if CI is working properly.
This enables @jpcornil-git to create the PR for the port of the new EOL code to 1.0 on the latest code.
So @t0mpr1c3, feel free to review/merge the PR.

@VIPQualityPost
Copy link

Are you sure we should merge to dev? I thought we don't want to do any ESP stuff until after 1.0 release. I agree we need a place to work on the refactor though. Maybe we can have a post-1.0 branch?

@dl1com
Copy link
Contributor Author

dl1com commented Feb 26, 2024

Are you sure we should merge to dev? I thought we don't want to do any ESP stuff until after 1.0 release. I agree we need a place to work on the refactor though. Maybe we can have a post-1.0 branch?

Thanks for pointing that out.
Then I propose to just close this PR without merging and use this ayab-esp32 branch for this purpose.

@VIPQualityPost
Copy link

Agreed, let's just keep like that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants