Common: customize BigScreen colors #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
Add customization of the foreground and backgound colors for the BigScreen. The colors can be modified via two new custom parameters (`foregroundColor` and `backgroundColor`), both accepting only ROOT color indexes as values. The code has also been updated to use the `getFromExtendedConfig()` function to extract the custom parameter values.
aferrero2707
force-pushed
the
common-customize-bigscreen-colors
branch
from
d64df0d to
a09542f
Compare
Barthelemy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add customization of the foreground and backgound colors for the BigScreen. The colors can be modified via two new custom parameters (
foregroundColorandbackgroundColor), both accepting only ROOT color indexes as values.The code has also been updated to use the
getFromExtendedConfig()function to extract the custom parameter values.Here is an example of a dark color combination:
