use a dedicated method to update the metadata. At the moment te QCCDB…

… requires to specify the start of validity behind the scene.
AliceO2Group · Nov 1, 2023 · e4b576b · e4b576b
1 parent db27d46
commit e4b576b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/Framework/script/RepoCleaner/qcrepocleaner/Ccdb.py b/Framework/script/RepoCleaner/qcrepocleaner/Ccdb.py
@@ -200,7 +200,24 @@ def updateValidity(self, version: ObjectVersion, valid_from: int, valid_to: int,
         except requests.exceptions.RequestException as e:  
             logging.error(f"Exception in updateValidity: {traceback.format_exc()}")
 
+    @dryable.Dryable()
+    def updateMetadata(self, version: ObjectVersion, metadata):
+        logger.debug(f"update metadata : {metadata}")
+        full_path = self.url + '/' + version.path + '/' + str(version.validFrom) + '/' + str(version.uuid) + '?'
+        if metadata is not None:
+            for key in metadata:
+                full_path += key + "=" + metadata[key] + "&"
+        if self.set_adjustable_eov:
+            logger.debug(f"As the parameter force is set, we add metadata adjustableEOV")
+            full_path += "adjustableEOV=1&"
+        try:
+            headers = {'Connection': 'close'}
+            r = requests.put(full_path, headers=headers)
+            r.raise_for_status()
+        except requests.exceptions.RequestException as e:
+            logging.error(f"Exception in updateMetadata: {traceback.format_exc()}")
 
+    @dryable.Dryable()
     def putVersion(self, version: ObjectVersion, data):
         '''
         :param version: An ObjectVersion that describes the data to be uploaded.

diff --git a/Framework/script/RepoCleaner/qcrepocleaner/rules/multiple_per_run.py b/Framework/script/RepoCleaner/qcrepocleaner/rules/multiple_per_run.py
@@ -11,6 +11,7 @@
 
 logger = logging  # default logger
 
+
 def process(ccdb: Ccdb, object_path: str, delay: int,  from_timestamp: int, to_timestamp: int,
             extra_params: Dict[str, str]):
     '''
@@ -110,8 +111,7 @@ def process(ccdb: Ccdb, object_path: str, delay: int,  from_timestamp: int, to_t
                     preservation_list.extend(run_versions)
                     continue
                 # flag second with `cleaner_2nd`
-                ccdb.updateValidity(run_versions[1], run_versions[1].validFrom, run_versions[1].validTo,
-                                    {'cleaner_2nd': 'true'})
+                ccdb.updateMetadata(run_versions[1], {'cleaner_2nd': 'true'})
                 # delete first and last versions in the bucket
                 logger.debug(f"        delete the first and last versions")
                 deletion_list.append(run_versions[-1])
@@ -132,7 +132,7 @@ def process(ccdb: Ccdb, object_path: str, delay: int,  from_timestamp: int, to_t
                     logger.debug(f" --> preserve")
                     last_preserved = v
                     if migrate_to_EOS:
-                        ccdb.updateValidity(v, v.validFrom, v.validTo, metadata_for_preservation)
+                        ccdb.updateMetadata(v, metadata_for_preservation)
                     preservation_list.append(last_preserved)
                 else:  # in between period --> delete
                     logger.debug(f" --> delete")