Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smaps_rollup everywhere #345

Closed
wants to merge 1 commit into from
Closed

Use smaps_rollup everywhere #345

wants to merge 1 commit into from

Conversation

ktf
Copy link
Member

@ktf ktf commented Jan 23, 2025

No description provided.

@ktf
Copy link
Member Author

ktf commented Jan 23, 2025

@vascobarroso can I get a release with this? We do not support SLC7 anymore in any case, no? We currently have a performance regression on Alma9 due to what is fixed here.

@vascobarroso
Copy link
Member

@sy-c could you have a look at Giulio's request above ?
Please check with DCS (Pete Bond) about the CC7 support, IIRC they needed it but they might also have plans to migrate.

@sy-c
Copy link
Collaborator

sy-c commented Jan 23, 2025

Hello, I don't know the context, but it seems to me that this fix can be made CC7 backward-compatible at no cost, with e.g.

#ifdef O2_MONITORING_OS_CC7
static constexpr auto SMAPS_FILE = "/proc/self/smaps";
#else
static constexpr auto SMAPS_FILE = "/proc/self/smaps_rollup";
#endif

@ktf
Copy link
Member Author

ktf commented Jan 23, 2025

Fair enough.

@ktf ktf closed this Jan 23, 2025
@ktf
Copy link
Member Author

ktf commented Jan 23, 2025

See #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktf @vascobarroso @sy-c