Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QC flags tests #1830

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix QC flags tests #1830

merged 1 commit into from
Jan 9, 2025

Conversation

martinboulais
Copy link
Collaborator

I DON'T have JIRA ticket

  • explain what this PR does

Notable changes for users:

  • N/A

Notable changes for developers:

  • Fixed randomly failing QC tests

Changes made to the database:

  • N/A

@martinboulais martinboulais self-assigned this Jan 9, 2025
@martinboulais martinboulais requested a review from graduta as a code owner January 9, 2025 15:22
@martinboulais martinboulais merged commit 86f5f39 into main Jan 9, 2025
21 checks passed
@martinboulais martinboulais deleted the mboulais/fix-qc-flags-tests branch January 9, 2025 15:36
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 44.06%. Comparing base (31b44ca) to head (a8feb56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ib/public/components/qcFlags/qcFlagsBreadcrumbs.js 0.00% 5 Missing ⚠️
...verview/DataPassesPerSimulationPassOverviewPage.js 0.00% 2 Missing ⚠️
...imulationPass/RunsPerSimulationPassOverviewPage.js 0.00% 2 Missing ⚠️
...edOverview/AnchoredSimulationPassesOverviewPage.js 0.00% 2 Missing ⚠️
...erview/SimulationPassesPerLhcPeriodOverviewPage.js 0.00% 2 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   44.05%   44.06%   +0.01%     
==========================================
  Files         889      889              
  Lines       15873    15869       -4     
  Branches     2997     2993       -4     
==========================================
  Hits         6993     6993              
+ Misses       8880     8876       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant