Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode URI components in buildURL function #1824

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

Notable changes for users:

  • N/A

Notable changes for developers:

  • Encode URI components in buildUrl utility function, to handle parameters with = sign in keys/values

Changes made to the database:

  • N/A

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.08%. Comparing base (86f5f39) to head (92d6c80).

Files with missing lines Patch % Lines
lib/public/utilities/fetch/buildUrl.js 0.00% 4 Missing ⚠️
.../Environments/Overview/EnvironmentOverviewModel.js 0.00% 1 Missing ⚠️
lib/public/views/Flps/Flps.js 0.00% 1 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 1 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 1 Missing ⚠️
lib/public/views/Tags/Details/TagDetailsModel.js 0.00% 1 Missing ⚠️
...ib/public/views/Tags/Overview/TagsOverviewModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   44.06%   44.08%   +0.01%     
==========================================
  Files         889      889              
  Lines       15869    15870       +1     
  Branches     2993     2993              
==========================================
+ Hits         6993     6996       +3     
+ Misses       8876     8874       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/encode-uri-components-in-build-url branch from 894d47a to 92d6c80 Compare January 10, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant