Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1405] Additional query parameters for creating a log #1809

Merged

Conversation

Jaden505
Copy link
Collaborator

@Jaden505 Jaden505 commented Dec 4, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

Notable changes for developers:

Changes made to the database:

@Jaden505 Jaden505 added backend javascript Pull requests that update Javascript code labels Dec 4, 2024
@Jaden505 Jaden505 self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 44.05%. Comparing base (932d354) to head (13cfdb2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lic/views/Logs/Create/TemplatedLogCreationModel.js 0.00% 7 Missing ⚠️
lib/public/views/Logs/LogsModel.js 0.00% 7 Missing ⚠️
...c/views/Logs/Create/templates/OnCallLogTemplate.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1809      +/-   ##
==========================================
+ Coverage   44.02%   44.05%   +0.03%     
==========================================
  Files         889      889              
  Lines       15863    15873      +10     
  Branches     2991     2997       +6     
==========================================
+ Hits         6983     6993      +10     
  Misses       8880     8880              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/public/views/Logs/Create/LogCreationModel.js Outdated Show resolved Hide resolved
lib/public/views/Logs/Create/LogCreationModel.js Outdated Show resolved Hide resolved
lib/public/views/Logs/Create/TemplatedLogCreationModel.js Outdated Show resolved Hide resolved
lib/public/views/Logs/LogsModel.js Show resolved Hide resolved
lib/public/views/Logs/Create/TemplatedLogCreationModel.js Outdated Show resolved Hide resolved
lib/server/services/log/LogService.js Outdated Show resolved Hide resolved
test/public/logs/create.test.js Outdated Show resolved Hide resolved
lib/public/views/Logs/LogsModel.js Show resolved Hide resolved
lib/server/services/log/LogService.js Outdated Show resolved Hide resolved
lib/public/views/Logs/Create/logCreationComponent.js Outdated Show resolved Hide resolved
@Jaden505 Jaden505 requested a review from martinboulais January 7, 2025 09:39
@Jaden505 Jaden505 merged commit 639e634 into main Jan 7, 2025
22 of 23 checks passed
@Jaden505 Jaden505 deleted the feature/jadenvr/O2B-1405/log-create-additional-query-params branch January 7, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants