-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1393] Use certificate when handling lost runs and envs #1793
Merged
martinboulais
merged 16 commits into
main
from
mboulais/O2B-1393/use-certificate-when-handling-lost-runs-and-envs
Jan 24, 2025
Merged
[O2B-1393] Use certificate when handling lost runs and envs #1793
martinboulais
merged 16 commits into
main
from
mboulais/O2B-1393/use-certificate-when-handling-lost-runs-and-envs
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
=======================================
Coverage 44.04% 44.05%
=======================================
Files 891 891
Lines 15967 15971 +4
Branches 3016 3020 +4
=======================================
+ Hits 7033 7036 +3
- Misses 8934 8935 +1 ☔ View full report in Codecov by Sentry. |
Tested on openstack, request to ECS p2 works fine from here, but I was not able to test much further. |
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
graduta
approved these changes
Jan 23, 2025
…ing-lost-runs-and-envs
…ing-lost-runs-and-envs
martinboulais
deleted the
mboulais/O2B-1393/use-certificate-when-handling-lost-runs-and-envs
branch
January 24, 2025 07:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: