Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1393] Use certificate when handling lost runs and envs #1793

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Fixed error spamming server logs when trynig to handle lost runs and envs

Changes made to the database:

  • N/A

@martinboulais martinboulais added the bug Something isn't working label Nov 4, 2024
@martinboulais martinboulais self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 44.05%. Comparing base (1a9f97b) to head (3fc88c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/application.js 23.80% 16 Missing ⚠️
...ices/housekeeping/handleLostRunsAndEnvironments.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1793   +/-   ##
=======================================
  Coverage   44.04%   44.05%           
=======================================
  Files         891      891           
  Lines       15967    15971    +4     
  Branches     3016     3020    +4     
=======================================
+ Hits         7033     7036    +3     
- Misses       8934     8935    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais
Copy link
Collaborator Author

Tested on openstack, request to ECS p2 works fine from here, but I was not able to test much further.

@martinboulais martinboulais merged commit 2031879 into main Jan 24, 2025
22 of 23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1393/use-certificate-when-handling-lost-runs-and-envs branch January 24, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants