Skip to content
This repository has been archived by the owner on Oct 19, 2020. It is now read-only.

Don't swallow errors if fail to generate icon #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ var generateIcon = function (platform, icon) {
} , function(err, stdout, stderr){
if (err) {
deferred.reject(err);
display.error('Failed to create ' + icon.name);
} else {
deferred.resolve();
display.success(icon.name + ' created');
Expand Down Expand Up @@ -280,6 +281,10 @@ var generateIcons = function (platforms) {
});
Q.all(all).then(function () {
deferred.resolve();
}).catch(function (err) {
if (err) {
deferred.reject(err);
}
});
return deferred.promise;
};
Expand Down