Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update invalid github-app-token regex #5

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Update invalid github-app-token regex #5

wants to merge 13 commits into from

Conversation

lem-onade
Copy link
Member

@lem-onade lem-onade commented Jul 9, 2024 •
edited
Loading

Description:

The old regex made it so only the capturing group was returned as secret value.
(note ghp_ value is not a github-app-token)

image

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

dutchhaag and others added 12 commits February 15, 2024 11:54
@dutchhaag
patching golang.org/x/text for CVE-2021-38561 and CVE-2022-32149 (git…
247a5e7 
…leaks#1342)
@baruchiro
fix: age rule id with dashes (gitleaks#1349)
6c52f87
@jporzucek
Append ordered rules when extending (gitleaks#1304)
59c0cc7
update mailchimp with new tokens (gitleaks#1376)
979f213
feat: facebook secret, access token, and page access token rules (git…
4b54328 
…leaks#1372)

* Add Facebook secret, access token, and page access token rules

* comment
add update token from square (gitleaks#1370)
db69e82
@katrinleinweber
Update "contributing guidelines" link (gitleaks#1390)
57ac4b3
@baruchiro
Add Cloudflare API and Origin CA keys (gitleaks#1374)
821b232 
* add real heroku example

* Add Cloudflare API and Origin CA keys

---------

Co-authored-by: Baruch Odem <[email protected]>
@baruchiro
add real (test) standard and restricted keys (gitleaks#1375)
247f423 
Co-authored-by: Baruch Odem <[email protected]>
@baruchiro
tests: scalingo validation consistent test (gitleaks#1359)
79cac73 
* Refactor Scalingo API token regex and add sample token

* improve docs for allowlist

I didn't know it when I made gitleaks#1358

---------

Co-authored-by: Baruch Odem <[email protected]>
@willem-delbare
Merge branch 'gitleaks:master' into master
0b97de5
@lem-onade
fix: add non-capturing group for github-app-token regex
271ae89
@lem-onade lem-onade self-assigned this Jul 9, 2024
@lem-onade lem-onade changed the title Add non-capturing group for github-app-token regex Update github-app-token regex with non-capturing group Jul 9, 2024
@lem-onade lem-onade changed the title Update github-app-token regex with non-capturing group Update invalid github-app-token regex Jul 9, 2024
@lem-onade lem-onade marked this pull request as ready for review July 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lem-onade lem-onade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lem-onade @dutchhaag @baruchiro @jporzucek @katrinleinweber @willem-delbare