Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.6.1 #64

Merged
merged 3 commits into from
Nov 25, 2024
Merged

v3.6.1 #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15d2703
Make various properties nullable and set default values
Afischbacher Nov 25, 2024
5481c7b
Bump project version to 3.6.1
Afischbacher Nov 25, 2024
056cdf8
Make SeasonId non-nullable in PlayerTimeOnIceStatistics
Afischbacher Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Nhl.Api.Common/Nhl.Api.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>3.6.0</Version>
<Version>3.6.1</Version>
<TargetFrameworks>net8.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Statistics/PlayerRealtimeStatisticsFilterResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public class PlayerRealtimeStatisticsResult
/// Hits per 60 minutes.
/// </summary>
[JsonProperty("hitsPer60")]
public double HitsPer60 { get; set; }
public double? HitsPer60 { get; set; }

/// <summary>
/// Player's last name.
Expand Down Expand Up @@ -186,7 +186,7 @@ public class PlayerRealtimeStatisticsResult
/// Takeaways per 60 minutes.
/// </summary>
[JsonProperty("takeawaysPer60")]
public double TakeawaysPer60 { get; set; }
public double? TakeawaysPer60 { get; set; }

/// <summary>
/// Team abbreviation.
Expand Down
14 changes: 7 additions & 7 deletions Nhl.Api.Domain/Models/Statistics/PlayerStatisticsFilterResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,21 @@ public class PlayerStatisticsResult
/// Example: 2
/// </summary>
[JsonProperty("gameWinningGoals")]
public int GameWinningGoals { get; set; }
public int? GameWinningGoals { get; set; }
Afischbacher marked this conversation as resolved.
Show resolved Hide resolved

/// <summary>
/// The NHL player games played <br/>
/// Example: 78
/// </summary>
[JsonProperty("gamesPlayed")]
public int GamesPlayed { get; set; }
public int? GamesPlayed { get; set; }

/// <summary>
/// The NHL player goals <br/>
/// Example: 10
/// </summary>
[JsonProperty("goals")]
public int Goals { get; set; }
public int? Goals { get; set; }

/// <summary>
/// The NHL player last name <br/>
Expand All @@ -87,14 +87,14 @@ public class PlayerStatisticsResult
/// Example: 1
/// </summary>
[JsonProperty("otGoals")]
public int OvertimeGoals { get; set; }
public int? OvertimeGoals { get; set; }

/// <summary>
/// The NHL player penalty minutes <br/>
/// Example: 20
/// </summary>
[JsonProperty("penaltyMinutes")]
public int PenaltyMinutes { get; set; }
public int? PenaltyMinutes { get; set; }

/// <summary>
/// The NHL player player identifier <br/>
Expand All @@ -115,14 +115,14 @@ public class PlayerStatisticsResult
/// Example: 20
/// </summary>
[JsonProperty("points")]
public int Points { get; set; }
public int? Points { get; set; }

/// <summary>
/// The NHL player points per game <br/>
/// Example: 0.356732
/// </summary>
[JsonProperty("pointsPerGame")]
public decimal PointsPerGame { get; set; }
public decimal? PointsPerGame { get; set; }

/// <summary>
/// The NHL player position code <br/>
Expand Down
18 changes: 9 additions & 9 deletions Nhl.Api.Domain/Models/Statistics/PlayerTimeOnIceStatisticsFilterResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ public class PlayerTimeOnIceStatisticsResult
/// Even strength time on ice in seconds.
/// </summary>
[JsonProperty("evTimeOnIce")]
public int EvTimeOnIce { get; set; }
public int? EvTimeOnIce { get; set; }

/// <summary>
/// Even strength time on ice per game in seconds.
/// </summary>
[JsonProperty("evTimeOnIcePerGame")]
public double EvTimeOnIcePerGame { get; set; }
public double? EvTimeOnIcePerGame { get; set; }

/// <summary>
/// Number of games played.
Expand All @@ -54,13 +54,13 @@ public class PlayerTimeOnIceStatisticsResult
/// Overtime time on ice in seconds.
/// </summary>
[JsonProperty("otTimeOnIce")]
public int OtTimeOnIce { get; set; }
public int? OtTimeOnIce { get; set; }

/// <summary>
/// Overtime time on ice per overtime game in seconds.
/// </summary>
[JsonProperty("otTimeOnIcePerOtGame")]
public double OtTimeOnIcePerOtGame { get; set; }
public double? OtTimeOnIcePerOtGame { get; set; }

/// <summary>
/// Player's ID.
Expand All @@ -78,13 +78,13 @@ public class PlayerTimeOnIceStatisticsResult
/// Power play time on ice in seconds.
/// </summary>
[JsonProperty("ppTimeOnIce")]
public int PpTimeOnIce { get; set; }
public int? PpTimeOnIce { get; set; }

/// <summary>
/// Power play time on ice per game in seconds.
/// </summary>
[JsonProperty("ppTimeOnIcePerGame")]
public double PpTimeOnIcePerGame { get; set; }
public double? PpTimeOnIcePerGame { get; set; }

/// <summary>
/// Season ID.
Expand All @@ -96,13 +96,13 @@ public class PlayerTimeOnIceStatisticsResult
/// Short-handed time on ice in seconds.
/// </summary>
[JsonProperty("shTimeOnIce")]
public int ShTimeOnIce { get; set; }
public int? ShTimeOnIce { get; set; }

/// <summary>
/// Short-handed time on ice per game in seconds.
/// </summary>
[JsonProperty("shTimeOnIcePerGame")]
public double ShTimeOnIcePerGame { get; set; }
public double? ShTimeOnIcePerGame { get; set; }

/// <summary>
/// Number of shifts.
Expand Down Expand Up @@ -138,7 +138,7 @@ public class PlayerTimeOnIceStatisticsResult
/// Total time on ice in seconds.
/// </summary>
[JsonProperty("timeOnIce")]
public int TimeOnIce { get; set; }
public int? TimeOnIce { get; set; }

/// <summary>
/// Time on ice per game in seconds.
Expand Down
2 changes: 1 addition & 1 deletion Nhl.Api.Domain/Nhl.Api.Domain.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>3.6.0</Version>
<Version>3.6.1</Version>
<TargetFrameworks>net8.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Tests/Nhl.Api.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>3.6.0</Version>
<Version>3.6.1</Version>
<TargetFramework>net8.0</TargetFramework>
<IsPackable>false</IsPackable>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
Expand Down
2 changes: 1 addition & 1 deletion Nhl.Api/Nhl.Api.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>3.6.0</Version>
<Version>3.6.1</Version>
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Nhl.Api</PackageId>
<Title>Nhl.Api</Title>
Expand Down
Loading