Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.5.0 #60

Merged
merged 21 commits into from
Sep 30, 2024
Merged

v3.5.0 #60

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cb810b2
Add Utah Hockey Club, new stats methods, and update tests
Afischbacher Sep 21, 2024
bcc9d49
Enhance player stats; remove outdated methods
Afischbacher Sep 21, 2024
e43371c
Enable nullable returns and re-enable test cases
Afischbacher Sep 21, 2024
2cf0c94
Standardize using directives and improve code formatting
Afischbacher Sep 21, 2024
2071298
Update Nhl.Api/Src/StatisticsApi/INhlStatisticsApi.cs
Afischbacher Sep 21, 2024
eb40420
Update Nhl.Api/Src/Api/NhlApi.cs
Afischbacher Sep 21, 2024
7322674
Update Nhl.Api/Src/Api/NhlApi.cs
Afischbacher Sep 21, 2024
c20acdd
Update Nhl.Api.Tests/StatisticsTests.cs
Afischbacher Sep 21, 2024
03c2c8b
Update Nhl.Api.Tests/StatisticsTests.cs
Afischbacher Sep 21, 2024
efd974b
Update Nhl.Api.Tests/StatisticsTests.cs
Afischbacher Sep 21, 2024
c45cb24
Update Nhl.Api/Src/StatisticsApi/NhlStatisticsApi.cs
Afischbacher Sep 21, 2024
1fbabaa
Update Nhl.Api/Src/StatisticsApi/NhlStatisticsApi.cs
Afischbacher Sep 21, 2024
b3381cc
Update Nhl.Api.Tests/StatisticsTests.cs
Afischbacher Sep 21, 2024
283301c
Update Nhl.Api.Tests/StatisticsTests.cs
Afischbacher Sep 21, 2024
67a50d0
Update method docs for clarity on filter expressions
Afischbacher Sep 21, 2024
2502ea7
Update Nhl.Api.Domain/Services/NhlTeamService.cs
Afischbacher Sep 21, 2024
4f97959
Update retry logic and clean up comments
Afischbacher Sep 22, 2024
8c1f8a4
Merge branch 'develop' of https://github.com/Afischbacher/Nhl.Api int…
Afischbacher Sep 22, 2024
d347fd8
Fixed post comment updates
Afischbacher Sep 22, 2024
7ebac93
Fixing bug regarding box score API replacement
Afischbacher Sep 30, 2024
e9a494b
Fixing comments for assert
Afischbacher Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Nhl.Api.Common/Helpers/TeamNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Nhl.Api.Common.Helpers;
namespace Nhl.Api.Common.Helpers;

/// <summary>
/// A helper class for all NHL team names
Expand Down Expand Up @@ -164,4 +164,9 @@ public static class TeamNames
/// Winnipeg Jets
/// </summary>
public const string WinnipegJets = "Winnipeg Jets";

/// <summary>
/// Utah Hockey Club
/// </summary>
public const string UtahHockeyClub = "Utah Hockey Club";
}
Afischbacher marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion Nhl.Api.Common/Http/NhlApiHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
using Newtonsoft.Json;
using System;
using System.Net;
using System.Net.Http;
using System.Threading;
using System.Threading.Tasks;
using Newtonsoft.Json;

namespace Nhl.Api.Common.Http;
/// <summary>
Expand Down Expand Up @@ -59,7 +59,7 @@
/// <summary>
/// The Nhl.Api HTTP Client
/// </summary>
public NhlApiHttpClient(string clientApiUri, string clientVersion, int timeoutInSeconds = 30)

Check warning on line 62 in Nhl.Api.Common/Http/NhlApiHttpClient.cs

View workflow job for this annotation

GitHub Actions / build 

Non-nullable property 'HttpClient' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
{
ServicePointManager.ReusePort = true;
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls13 | SecurityProtocolType.Tls12;
Expand Down
2 changes: 1 addition & 1 deletion Nhl.Api.Common/Nhl.Api.Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Version>3.4.2</Version>
<Version>3.5.0</Version>
<TargetFrameworks>net8.0</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
Expand Down
2 changes: 1 addition & 1 deletion Nhl.Api.Common/Services/CachingService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
using Newtonsoft.Json;
using System;
using System.Collections.Concurrent;
using System.IO;
using System.IO.Compression;
using System.Text;
using System.Threading.Tasks;
using Newtonsoft.Json;

namespace Nhl.Api.Common.Services;
/// <summary>
Expand Down
8 changes: 6 additions & 2 deletions Nhl.Api.Domain/Enumerations/Franchise/FranchiseEnum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Nhl.Api.Models.Enumerations.Franchise;
namespace Nhl.Api.Models.Enumerations.Franchise;

/// <summary>
/// An enumeration of all NHL franchises
Expand Down Expand Up @@ -160,5 +160,9 @@ public enum FranchiseEnum
/// <summary>
/// Seattle Kraken
/// </summary>
SeattleKraken = 39
SeattleKraken = 39,
/// <summary>
/// Utah Hockey Club
/// </summary>
UtahHockeyClub = 40
}
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Enumerations/Player/PlayerEnumFileGeneratorHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
using Nhl.Api.Common.Http;
using Nhl.Api.Models.Player;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using Nhl.Api.Common.Http;
using Nhl.Api.Models.Player;

namespace Nhl.Api.Models.Enumerations.Player;
/// <summary>
Expand Down
10 changes: 7 additions & 3 deletions Nhl.Api.Domain/Enumerations/Team/TeamEnum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Nhl.Api.Models.Enumerations.Team;
namespace Nhl.Api.Models.Enumerations.Team;

/// <summary>
/// An enumeration for all active NHL teams
Expand Down Expand Up @@ -132,5 +132,9 @@ public enum TeamEnum
/// <summary>
/// Seattle Kraken
/// </summary>
SeattleKraken = 55
}
SeattleKraken = 55,
/// <summary>
/// Utah Hockey Club
/// </summary>
UtahHockeyClub = 59
}
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameCenterBoxScore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameCenterLanding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System;
using System.Collections.Generic;
using Newtonsoft.Json;
using Nhl.Api.Models.Player;
using Nhl.Api.Models.Standing;
using System;
using System.Collections.Generic;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameCenterPlayByPlay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Newtonsoft.Json;
using Nhl.Api.Models.Player;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;
using Nhl.Api.Models.Player;

namespace Nhl.Api.Models.Game;

Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using Newtonsoft.Json;
using System.Collections.Generic;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameScore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GameScoreboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/GoalieSeasonGameLog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System.Collections.Generic;
using Newtonsoft.Json;
using Nhl.Api.Models.Team;
using System.Collections.Generic;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/PlayerSeasonGameLog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System.Collections.Generic;
using Newtonsoft.Json;
using Nhl.Api.Models.Team;
using System.Collections.Generic;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/TeamScoreboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/Game/TvScheduleBroadcast.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using Newtonsoft.Json;
using System;
using System;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.Game;
/// <summary>
Expand Down
4 changes: 2 additions & 2 deletions Nhl.Api.Domain/Models/League/LeagueMetadataInformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using Newtonsoft.Json;
using System.Collections.Generic;
using System.Collections.Generic;
using Newtonsoft.Json;

namespace Nhl.Api.Models.League;
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion Nhl.Api.Domain/Models/Player/ExpressionGoalieFilterBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using Nhl.Api.Common.Extensions;
using System.ComponentModel;
using System.Runtime.Serialization;
using System.Text;
using Nhl.Api.Common.Extensions;

namespace Nhl.Api.Models.Player;
/// <summary>
Expand Down
Loading
Loading