Skip to content

Commit

Permalink
Disabling group properties being updated due to an API bug whereby it…
Browse files Browse the repository at this point in the history
… thinks the default visibility level should be applied even though it's not specified in the API call.

Confirmed bug: https://gitlab.com/gitlab-org/gitlab-ce/issues/48764
  • Loading branch information
Adambean committed Jan 25, 2019
1 parent b2979db commit 4842e91
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/LdapSyncCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -1305,12 +1305,14 @@ private function deployGitlabUsersAndGroups(array $config, string $gitlabInstanc
}
$ldapGroupMembers = $ldapGroupsSafe[$gitlabGroupName];

/*
!$this->dryRun ? ($gitlabGroup = $gitlab->api("groups")->update($gitlabGroupId, [
// "name" => $gitlabGroupName,
// No point updating that. ^
// If the CN changes so will that bit of the DN anyway, so this can't be detected with a custom attribute containing the Gitlab group ID written back to group's LDAP object.
"path" => $gitlabGroupPath,
])) : $this->logger->warning("Operation skipped due to dry run.");
*/

$groupsSync["update"][$gitlabGroupId] = $gitlabGroupName;
}
Expand Down

0 comments on commit 4842e91

Please sign in to comment.