Update examples #242
Merged
Update examples #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukacan
requested changes
Jan 12, 2025
| @@ -1,11 +1,13 @@ | |||
| [workspace] | |||
| members = ["programs/*", "trident-tests/fuzz_tests"] | |||
| members = [ | |||
| "programs/*", "trident-tests" | |||
There was a problem hiding this comment.
"trident-tests" should not be there
|
|
||
| [profile.release] | ||
| overflow-checks = true | ||
| lto = "fat" | ||
| codegen-units = 1 | ||
|
|
There was a problem hiding this comment.
please do not commit changes like this, it adds overhead to comparison
examples/cpi/simple-cpi-6/Cargo.toml
Outdated
| @@ -1,5 +1,6 @@ | |||
| [workspace] | |||
| members = ["programs/*"] | |||
|
|
|||
| @@ -5,7 +5,7 @@ resolution = true | |||
| skip-lint = false | |||
|
|
|||
| [programs.localnet] | |||
| maze = "5s76RezGLb7dthzSzcFSpJAvXH6ZRsPenbGwrjtbq2mY" | |||
| maze0 = "HLUXYVSNW3unyAvuJW3C2MRH48X6vuiSAYzAE2sAm2L3" | |||
There was a problem hiding this comment.
why is the program ID and name changed ?
There was a problem hiding this comment.
I don't think these changes are necessary
| @@ -2,8 +2,6 @@ | |||
| name = "fuzz_0" | |||
| path = "fuzz_0/test_fuzz.rs" | |||
|
|
|||
| [workspace] | |||
There was a problem hiding this comment.
to have dedicated workspace is intentional
|
|
||
| [dependencies.maze] | ||
| path = "../programs/maze" | ||
| [dependencies.maze0] |
| @@ -5,7 +5,7 @@ resolution = true | |||
| skip-lint = false | |||
|
|
|||
| [programs.localnet] | |||
| maze = "5s76RezGLb7dthzSzcFSpJAvXH6ZRsPenbGwrjtbq2mY" | |||
| maze1 = "Fd1hRfkay2Q7C4fxqqa3meZZpjULrBi1yZA7Mc6R5mmV" | |||
| @@ -1,5 +1,5 @@ | |||
| [workspace] | |||
| members = ["programs/*"] | |||
| members = ["programs/*", "trident-tests"] | |||
lukacan
force-pushed
the
update/examples
branch
from
34ecad4 to
03677d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update benchmark mazes and unauthorized access examples.
Related Tickets & Documents
Related Issue #
Closes #
I clicked on "Allow edits from maintainers"