Workaround CI workflow for vfx 2022/2021 #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build for VFX reference platform prior to 2023, which requires a workaround to run an old version of glibc required by the ASWF Docker images. This doesn't easily integrate with the existing CI workflow, and it can be deprecated entirely once we've moved beyond support for the old CentOS-based VFX reference platform years. See this discussion for details: https://academysoftwarefdn.slack.com/archives/C0169RX7MMK/p1732574400981949 Signed-off-by: Cary Phillips <[email protected]>
lgritz
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Changes LGTM and more or less echo what I did on OIIO and OSL.
GitHub doesn't let me add comments to sections that you didn't change! But ci_workflow.yml line 58 is actually mislabeled -- it says that these tests are centos7, but they are no longer. It's the "old" ci workflow that's using the centos7 based iamges.
Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for VFX reference platform prior to 2023, which requires a workaround to run an old version of glibc required by the ASWF Docker images.
This doesn't easily integrate with the existing CI workflow, and it can be deprecated entirely once we've moved beyond support for the old CentOS-based VFX reference platform years.
See this discussion for details:
https://academysoftwarefdn.slack.com/archives/C0169RX7MMK/p1732574400981949