Set a maximum number of datasets for each user #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `createDataset_service` function to make it checks if the user has reached the maximum number datasets or not before adding the new dataset, if he has, a failure result will be returned.
Make `createDataset_service` function creates a new user datasets docment if the user has not one, Create `successfulDatasetCreation` to reuse it to register the new dataset creation activity and to return the success result Also cancel using transaction session because there is only one write operation and there is no need to transactions. Also delete failedDatasetCreation method from `operationsResultsMessages` object because its usage is strange and doesn't have a clear reason behind it.
Codecov ReportAttention: Patch coverage is
|
AbdulrhmanGoni
deleted the
feature/maximum-number-of-datasets-for-each-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.