Merge pull request #71 from AbdulrhmanGoni/feature/not-allowed-empty-…

…update-payloads

Make updates middlewares reject the empty update payloads

src/middlewares/updateDatasetInputValidator.ts

@@ -5,16 +5,26 @@ import type { ValidationError } from "../types/validation";
 import validationSchema from "../validation/validationSchema";
 import DatasetSchemaRule from "../validation/DatasetSchemaRule";
 import RequiredObjectIdRule from "../validation/RequiredObjectIdRule";
+import haveSharedKey from "../utilities/haveSharedKey";
+
+const DatasetBaseRules = DatasetSchemaRule();
 
 const updateDatasetInputSchema = validationSchema<
   UpdateDatasetInput & { datasetId: Dataset["id"] }
 >({
   datasetId: RequiredObjectIdRule(),
-  ...DatasetSchemaRule(),
+  ...DatasetBaseRules,
 });
 
+export const emptyUpdateDatasetBodyMessage =
+  "You have to choose at least one field of the dataset to update it";
+
 export default function updateDatasetInputValidator(request: Req) {
   try {
+    if (haveSharedKey(DatasetBaseRules, request.json)) {
+      return ErrorResponse(emptyUpdateDatasetBodyMessage, 400);
+    }
+
     const { datasetId, ...updateData } = updateDatasetInputSchema.validate({
       ...request.json,
       datasetId: request.params.datasetId,

src/middlewares/updateInstructionInputValidator.ts

@@ -9,6 +9,9 @@ import type {
   UpdateInstructionInput,
 } from "../types/instructions";
 import InstructionSchemaRules from "../validation/InstructionSchemaRules";
+import haveSharedKey from "../utilities/haveSharedKey";
+
+const InstructionBaseRules = InstructionSchemaRules();
 
 const updateInstructionInputSchema = validationSchema<
   {
@@ -18,11 +21,18 @@ const updateInstructionInputSchema = validationSchema<
 >({
   datasetId: RequiredObjectIdRule(),
   instructionId: RequiredObjectIdRule(),
-  ...InstructionSchemaRules(),
+  ...InstructionBaseRules,
 });
 
+export const emptyUpdateInstructionBodyMessage =
+  "You have to choose at least one field of the instruction to update it";
+
 export default function updateInstructionInputValidator(request: Req) {
   try {
+    if (haveSharedKey(InstructionBaseRules, request.json)) {
+      return ErrorResponse(emptyUpdateInstructionBodyMessage, 400);
+    }
+
     const { datasetId, instructionId, ...updateData } =
       updateInstructionInputSchema.validate({
         datasetId: request.search.datasetId,

src/utilities/haveSharedKey.ts

@@ -0,0 +1,3 @@
+export default function haveSharedKey(object: object, target: object): boolean {
+  return !Object.keys(object).some((key) => Object.hasOwn(target, key));
+}