Signal.update() to include all fields #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishokamp
requested changes
Mar 18, 2023
There was a problem hiding this comment.
@complementizer thank you for this
i will take a pass now and directly push to this PR if that's ok?
then we can sync next week
| @@ -286,16 +292,17 @@ def anomaly_signal( | |||
| :param: history_length: history length | |||
| :param: history_interval: history interval (months, days, hours, ...) | |||
| """ | |||
| if not overwrite_existing and 'anomalies' in self.timeseries_df.columns: | |||
| if not self.timeseries_df["anomalies"].isnull().values.any(): | |||
| return self | |||
There was a problem hiding this comment.
we should check dependent on the dates specified by the user, not globally
| @@ -399,6 +414,26 @@ def from_dict(data): | |||
| args['feeds_df'] = args.pop('stories_df') | |||
| return signal_type.from_dict(args) | |||
|
|
|||
| def copy(self, included_columns=None): | |||
There was a problem hiding this comment.
i think we may be able to use self.from_dict for this, need to double check
| @@ -510,6 +544,26 @@ def from_dict(data): | |||
| ts_column=data['ts_column'], | |||
| ) | |||
|
|
|||
| def copy(self, included_columns=None): | |||
There was a problem hiding this comment.
try to put this on base class
| @@ -643,7 +728,7 @@ def update(self, start=None, end=None, freq='D', ts_endpoint=None): | |||
| any new data while retaining the existing information as well | |||
| :param start: datetime | |||
| :param end: datetime | |||
| """ | |||
| """ | |||
There was a problem hiding this comment.
try to put this on base class
| @@ -677,22 +764,53 @@ def update(self, start=None, end=None, freq='D', ts_endpoint=None): | |||
| # we're only going to be clever about extending to the right, | |||
| # if user wants historical data (before the data we already have), | |||
| # everything's getting retrieved | |||
| if self.timeseries_df is not None and start in self.timeseries_df.index: | |||
| if self.timeseries_df is not None and start in self.timeseries_df.index: | |||
| period = self.pd_freq_to_aylien_period(freq) | ||
| aylien_ts_df = self.query_news_signals(start, end, period, ts_endpoint) | ||
| if self.timeseries_df is None: | ||
| self.timeseries_df = aylien_ts_df | ||
| else: | ||
| else: |
@chrishokamp yep sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal.update() includes anomalies, summaries and wikipedia-pageviews if present.
I changed
signal.anomaly_signal()a bit to make it work and added asignal.copy()to all signal classes.