Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
chrishokamp committed Dec 4, 2023
1 parent 696d304 commit aa2173e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ These notebooks let you try out `news-signals` without installing anything!

The Colab notebooks above are also available as jupyter notebooks in [research/news-signals-example-notebooks](research/news-signals-example-notebooks)

**NEW**: [Create_Wikimedia_Signals.ipynb](research/news-signals-example-notebooks/Create_Wikimedia_Signals.ipynb) shows how to build and explore a `WikimediaSignal` which does not a NewsAPI account and works out-of-the-box for anyone.
**2023-11-30: NEW**: [Create_Wikimedia_Signals.ipynb](research/news-signals-example-notebooks/Create_Wikimedia_Signals.ipynb) shows how to build and explore a `WikimediaSignal` which does not a NewsAPI account and works out-of-the-box for anyone.

## Quickstart

Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.3.2
0.4.0
8 changes: 3 additions & 5 deletions news_signals/exogenous_signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,9 @@ def wikipedia_link_to_wikimedia_pageviews_timeseries(
########## TOOLS FOR SEARCHING WIKIPEDIA CURRENT EVENTS PORTAL ##########
#########################################################################

# Parsing the WCEP works with the code below but the page structures can change
# in the future, including past pages.



# Parsing the WCEP works with the code below as of 2023-11-30,
# but note that the page structures can change
# in the future, including the structure of past pages.
MONTH_NAMES = list(calendar.month_name)[1:]


Expand Down
2 changes: 1 addition & 1 deletion news_signals/signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ def add_wikimedia_pageviews_timeseries(
look at the params that were used to query the NewsAPI, and try to derive
a query to the wikimedia pageviews API from that.
For example, if there's no wikidata id in the NewsAPI query, this function should
For example, if there's no wikidata id, this function should
fail noisyly.
"""
if not overwrite_existing and "wikimedia_pageviews" in self.timeseries_df.columns:
Expand Down

0 comments on commit aa2173e

Please sign in to comment.