Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update UML diagrams" #53

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Revert "Update UML diagrams" #53

merged 1 commit into from
Mar 24, 2024

Conversation

Jolonauh
Copy link

@Jolonauh Jolonauh commented Mar 23, 2024

Reverts #49
Addresses #48

@Jolonauh Jolonauh requested review from Rishit02 and removed request for Rishit02 March 23, 2024 08:24
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (ae9a508) to head (d3be76d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     76.42%   76.42%           
  Complexity      448      448           
=========================================
  Files            73       73           
  Lines          1438     1438           
  Branches        141      141           
=========================================
  Hits           1099     1099           
  Misses          306      306           
  Partials         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jolonauh
Copy link
Author

Next of kin should be changed to "Next of Kin".
Description and Next of Kin should also be added as classes under the Model package.

Copy link

@Rishit02 Rishit02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rishit02 Rishit02 merged commit 6f4e8d2 into master Mar 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants