Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change edit command to update command #34

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Jolonauh
Copy link

@Jolonauh Jolonauh commented Mar 15, 2024

Previously an integer was provided to specify the target person to be edited. The changes are to use the full name of the target person instead. The full name provided as argument is not required to be case sensitive. The edit command is renamed to update.

Fix #17

Previously an integer was provided to specify the target person to be
edited. The new code changes that functionality to use the full name of
the target person instead. The full name provided as argument is not
required to be case sensitive.
@Jolonauh Jolonauh self-assigned this Mar 15, 2024
@Jolonauh Jolonauh changed the title Change the edit command to use a name Change edit command to update command Mar 15, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 90.41096% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.35%. Comparing base (859538a) to head (0151cd2).

Files Patch % Lines
...va/seedu/address/logic/commands/UpdateCommand.java 87.23% 1 Missing and 5 partials ⚠️
...eedu/address/logic/parser/UpdateCommandParser.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     76.33%   76.35%   +0.02%     
- Complexity      445      448       +3     
============================================
  Files            73       73              
  Lines          1424     1434      +10     
  Branches        140      141       +1     
============================================
+ Hits           1087     1095       +8     
- Misses          305      306       +1     
- Partials         32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jolonauh Jolonauh marked this pull request as ready for review March 17, 2024 13:19
Copy link

@pjanthony2001 pjanthony2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues, but overall LGTM. The testcases might need to be checked once more, because when the old files got deleted, there is no diff to compare to.

@pjanthony2001
Copy link

Also, I think you can safely ignore the CodeCov partial

@pjanthony2001 pjanthony2001 merged commit 5d71f72 into AY2324S2-CS2103T-W12-4:master Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a social worker, I can update my clients contact details
2 participants