-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change edit command to update command #34
Change edit command to update command #34
Conversation
Previously an integer was provided to specify the target person to be edited. The new code changes that functionality to use the full name of the target person instead. The full name provided as argument is not required to be case sensitive.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
============================================
+ Coverage 76.33% 76.35% +0.02%
- Complexity 445 448 +3
============================================
Files 73 73
Lines 1424 1434 +10
Branches 140 141 +1
============================================
+ Hits 1087 1095 +8
- Misses 305 306 +1
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues, but overall LGTM. The testcases might need to be checked once more, because when the old files got deleted, there is no diff to compare to.
Also, I think you can safely ignore the CodeCov partial |
Previously an integer was provided to specify the target person to be edited. The changes are to use the full name of the target person instead. The full name provided as argument is not required to be case sensitive. The edit command is renamed to update.
Fix #17