Fix issue #18 #33
Merged
Fix issue #18 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rishit02
commented
Mar 13, 2024
•
Rishit02
commented
- Fix issue Update "add" command to allow for these fields #18
- Add command includes Next Of Kin information and a description.
- Improves test cases to test whether Next Of Kin and description has been added correctly
Update add command to specify next of kin and description for Person
Change test case: include next of kin and description information
Test for add command is insufficient Let's, * improve the test case to include tests for next of kins * include tests for description
Jolonauh
reviewed
Mar 14, 2024
src/test/data/JsonAddressBookStorageTest/invalidAndValidPersonAddressBook.json
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
============================================
+ Coverage 76.05% 76.33% +0.28%
- Complexity 443 445 +2
============================================
Files 73 73
Lines 1424 1424
Branches 140 140
============================================
+ Hits 1083 1087 +4
+ Misses 307 305 -2
+ Partials 34 32 -2 ☔ View full report in Codecov by Sentry. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.