-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Undo and Redo commands #20
Add Undo and Redo commands #20
Conversation
Added initial classes required to implement the Undo and Redo commands
Resolved errors arising from missing JavaDoc statements and also added most of the logic and functionality
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
==================================================
+ Coverage 91.3080% 92.9216% +1.6136%
- Complexity 448 506 +58
==================================================
Files 63 70 +7
Lines 1185 1328 +143
Branches 131 135 +4
==================================================
+ Hits 1082 1234 +152
+ Misses 70 58 -12
- Partials 33 36 +3 ☔ View full report in Codecov by Sentry. |
Added placeholder tests for the new classes, and converted History into an interface that HistoryManager implemented
Added tests for coverage
This reverts commit 01f9380.
Updated Tests for ModelManager and State classes
Included tests for StartCommand class.
HistoryManager tests updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues with formatting. Should also relook at the use of ReadOnlyAddressBook and ObservableList in the State class
Made changes to State class according to review
Fixed naming of the testcases to match the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added initial classes required to implement the Undo and Redo commands. Fixes #19