Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Undo and Redo commands #20

Merged
merged 31 commits into from
Mar 29, 2024

Conversation

pjanthony2001
Copy link

@pjanthony2001 pjanthony2001 commented Mar 4, 2024

Added initial classes required to implement the Undo and Redo commands. Fixes #19

Added initial classes required to implement the Undo and Redo commands
Resolved errors arising from missing JavaDoc statements and also added
most of the logic and functionality
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.9216%. Comparing base (d1661ae) to head (377b2ad).

Files Patch % Lines
...ain/java/seedu/address/history/HistoryManager.java 90.9090% 0 Missing and 2 partials ⚠️
...rc/main/java/seedu/address/history/ModelState.java 90.0000% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##               master        #20        +/-   ##
==================================================
+ Coverage     91.3080%   92.9216%   +1.6136%     
- Complexity        448        506        +58     
==================================================
  Files              63         70         +7     
  Lines            1185       1328       +143     
  Branches          131        135         +4     
==================================================
+ Hits             1082       1234       +152     
+ Misses             70         58        -12     
- Partials           33         36         +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added placeholder tests for the new classes, and converted History into
an interface that HistoryManager implemented
Added tests for coverage
@pjanthony2001 pjanthony2001 self-assigned this Mar 4, 2024
@pjanthony2001 pjanthony2001 marked this pull request as ready for review March 26, 2024 05:19
Copy link

@Jolonauh Jolonauh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues with formatting. Should also relook at the use of ReadOnlyAddressBook and ObservableList in the State class

Made changes to State class according to review
Fix bugs that were made when updating the code to address issues
that were found during the code review
Fixed naming of the testcases to match the review
Copy link

@Jolonauh Jolonauh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/seedu/address/ui/MainWindow.java Outdated Show resolved Hide resolved
@pjanthony2001 pjanthony2001 added this to the v1.2b milestone Mar 28, 2024
@tejas-1405 tejas-1405 merged commit 3d892c2 into AY2324S2-CS2103T-W12-4:master Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a social worker, I can undo and redo my commands
3 participants