Added Lesson and Subject classes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlengch
added
the
Epic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
============================================
+ Coverage 74.60% 75.35% +0.75%
- Complexity 431 445 +14
============================================
Files 74 75 +1
Lines 1394 1473 +79
Branches 133 144 +11
============================================
+ Hits 1040 1110 +70
- Misses 320 324 +4
- Partials 34 39 +5 ☔ View full report in Codecov by Sentry. |
justinlengch
changed the title
| @@ -7,6 +7,8 @@ | |||
| * Guarantees: immutable; is always valid | |||
| */ | |||
| public class Remark { | |||
There was a problem hiding this comment.
will we be including the remark class?
| @@ -23,21 +24,28 @@ public static Person[] getSamplePersons() { | |||
| return new Person[] { | |||
| new Person(new Name("Alex Yeoh"), new Phone("87438807"), new Email("[email protected]"), | |||
| new Address("Blk 30 Geylang Street 29, #06-40"), | |||
| EMPTY_REMARK, getTagSet("friends")), | |||
| new Subject("Math"), | |||
| EMPTY_REMARK, getLessonSet("Maths|10-05-2004|12:29|0")), | |||
This was
linked to
issues
Mar 21, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deleted Tag class since I replaced it with Lesson