Add editing of Birthdays using the edit command #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinnzz
reviewed
Mar 16, 2024
| return true; | ||
| } | ||
| test = test.strip(); |
There was a problem hiding this comment.
Perhaps can consider using strip() or trim() in parseBirthday from ParserUtil although this works as well
| @@ -64,7 +64,8 @@ public void toStringMethod() { | |||
| + editPersonDescriptor.getName().orElse(null) + ", phone=" | |||
| + editPersonDescriptor.getPhone().orElse(null) + ", email=" | |||
| + editPersonDescriptor.getEmail().orElse(null) + ", address=" | |||
| + editPersonDescriptor.getAddress().orElse(null) + ", tags=" | |||
| + editPersonDescriptor.getAddress().orElse(null) + ", birthday=" | |||
| + editPersonDescriptor.getBirthday().orElse(null) + ", tags=" | |||
| + editPersonDescriptor.getTags().orElse(null) + "}"; | |||
There was a problem hiding this comment.
Should we standardize on whether to put birthday or tags in front or it doesnt really matter?
There was a problem hiding this comment.
Previously I encountered some bug, and I thought tags have to be at the back because tags can have multiple values so I put birthday before tags, but turns out it doesn't matter. So let's standardize and have new attributes be at the back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #27 and adds more test cases for BirthdayTest