Testing instructions #134
Merged
Testing instructions #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhekaiii
requested changes
Apr 15, 2024
docs/DeveloperGuide.md
Outdated
Comment on lines
1025
to
1026
| Expected: Person list now shows the filtered list of persons sorted based on upcoming birthdays, with those | ||
| whose birth month and birth day are closest to today appearing first. |
There was a problem hiding this comment.
I think you can rephrase to next birthday closest to today? Because later people niao our DG then say "the birthday is yesterday so it should appear first because 1 day difference".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testcases to appendix.
Please review to ensure no errors, especially for sort and pay which I am not that familiar with!