Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer guide #16

Merged

Conversation

Xilef121
Copy link

@Xilef121 Xilef121 commented Mar 6, 2024

This pull request enhances the project by incorporating essential user stories and defining crucial use cases. These additions are pivotal in shaping the direction of our development and ensuring we meet the needs and expectations of our users effectively.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (c6971f8) to head (cb9577c).

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SherwynNg SherwynNg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@AjayArvind2207 AjayArvind2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole, very good contributions 👍 ! Just some minor nits.

docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Copy link

@AjayArvind2207 AjayArvind2207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AjayArvind2207 AjayArvind2207 merged commit 4e0ee0d into AY2324S2-CS2103T-T13-2:master Mar 7, 2024
5 checks passed
@SherwynNg SherwynNg added this to the v1.1 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants