Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UG Related issues #203

Merged
merged 7 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -734,3 +734,5 @@ testers are expected to do more *exploratory* testing.
1. **Make the User Interface (UI) adapt to different window sizes:** Currently, the UI can only work at specific sizes, the user may need to adjust the window size such that all the components in the UI are visible during use, or when the application initially boots up. We plan to enhance the UI such that it is able to adapt to different window sizes and not have issues like components not being visible, or having white spaces when the window gets stretched too much.
2. **Standardizing Error Messages Related to Index:** Some error messages related to commands that utilizes Indexes (e.g `delete`, `note`) do not have standardized error messages. Users may sometimes see "The person index provided is invalid", or different error messages referring to the same error. We plan to standardize such messages so that they do not cause confusions for user and make the experience when using the application smoother.
3. **Allowing Contacts to Have the Same Name:** The application does not support people having the same name, even if they are two completely different person who just happens to have the same name. We plan to update this in the future such that this will become possible as it makes sense in the real world for two or more people to have the same name.
4. **Fix Feature Flaws of Profile Picture:** The profile picture feature may only work if users follows a very specific set of instructions to generate the `.json` file that stores the applicant information. This is due to buggy implementation of said feature, which did not follow the Command design pattern due to an oversight, which is thinking that the feature is a UI feature, so it does not need to follow the design pattern. We plan to fix this such that the feature will be able to work without strict constraints.
5. **UI Text Truncation Issues:** When some of the applicant's information is too long, it gets truncated and does not display properly. We plan to fix this in the future by creating a more robust UI that can adapt to applicant information with long length by displaying such information in a viewable and proper manner.
11 changes: 10 additions & 1 deletion docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,16 @@ If your changes to the data file makes its format invalid, HRConnect will discar
Furthermore, certain edits can cause the HRConnect to behave in unexpected ways (e.g., if a value entered is outside of the acceptable range). Therefore, edit the data file only if you are confident that you can update it correctly.
</div>


### Updating applicant profile picture (Part of Planned Enhancement)
Each applicant has a `Update Picture` button, which enables the user to add a profile picture for a particular applicant.
![Update Picture Button](images/updateProfilePicture.png)

**Note:** Due to buggy implementation of this feature, a very specific set of steps needs to be performed in order for this feature to work.
1. Before using this feature, use the `list` command at least once. This allows the `.json` file that stores the applicant information to be generated.
2. Press the `Update Picture` button and select an image (only image file types are supported, using other file types may corrupt the application).
3. After choosing an image, a popup should appear that explains to you that the application needs to be restarted for the changes to be reflected.
4. Restart the application, and you should be able to see the profile picture being updated.
5. In rare occasions, the feature may not work due to operating system complications.

## Command summary

Expand Down
Binary file added docs/images/updateProfilePicture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/ui/EmailWindow.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public class EmailWindow extends UiPart<Stage> {
+ "that we will be able to make the necessary arrangements.\n"
+ "The official hours are 9am to 6pm from Monday to Friday.\n"
+ "Do feel free to reply to this email should you have any questions.\n"
+ "We look forward to hearing back from you!n"
+ "We look forward to hearing back from you!\n"
+ "Best regards,\n"
+ "{organization} Talent Acquisition Team\n";

Expand Down
Loading