Skip to content

Commit

Permalink
Merge pull request #114 from lihaoquan/branch-ui-adjustment
Browse files Browse the repository at this point in the history
Branch UI adjustment
  • Loading branch information
lihaoquan authored Apr 4, 2024
2 parents 908ae16 + 9b32bb4 commit 99eca17
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 12 deletions.
9 changes: 6 additions & 3 deletions src/main/java/seedu/address/logic/commands/NoteCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static seedu.address.commons.util.CollectionUtil.requireAllNonNull;
import static seedu.address.logic.parser.CliSyntax.PREFIX_NOTE;
import static seedu.address.logic.parser.CliSyntax.PREFIX_NOTE_WITH_DATE;
import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;

import java.time.LocalDate;
Expand All @@ -24,12 +25,14 @@ public class NoteCommand extends Command {
public static final String COMMAND_WORD = "note";

public static final String MESSAGE_USAGE = COMMAND_WORD + ": Edits the note of the person identified "
+ "by the index number used in the last person listing. "
+ "by the index number used in the last person listing. The date field is optional. "
+ "Existing note will be overwritten by the input.\n"
+ "Parameters: INDEX (must be a positive integer) "
+ PREFIX_NOTE + "[NOTE]\n"
+ PREFIX_NOTE + " <NOTE> " + PREFIX_NOTE_WITH_DATE
+ " [true/false]\n"
+ "Example: " + COMMAND_WORD + " 1 "
+ PREFIX_NOTE + "Likes to swim.";
+ PREFIX_NOTE + "Likes to swim "
+ PREFIX_NOTE_WITH_DATE + " [true/false]";

public static final String MESSAGE_ADD_NOTE_SUCCESS = "Added note to Person: %1$s";
public static final String MESSAGE_DELETE_NOTE_SUCCESS = "Removed note from Person: %1$s";
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/view/ImportWindow.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<?import javafx.scene.layout.VBox?>
<?import javafx.stage.Stage?>

<fx:root resizable="false" title="Import" type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/21" xmlns:fx="http://javafx.com/fxml/1">
<fx:root resizable="false" title="Import" type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1">
<icons>
<Image url="@/images/import_icon.png" />
</icons>
Expand Down
8 changes: 4 additions & 4 deletions src/main/resources/view/MainWindow.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<fx:root minHeight="600" minWidth="650" maxHeight="960" onCloseRequest="#handleExit"
title="HRConnect"
type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/21" xmlns:fx="http://javafx.com/fxml/1">
type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1">
<icons>
<Image url="@/images/address_book_32.png" />
</icons>
Expand Down Expand Up @@ -219,7 +219,7 @@
</TitledPane>
</children>
</VBox>
<VBox HBox.hgrow="ALWAYS">
<VBox VBox.vgrow="ALWAYS">
<children>

<StackPane fx:id="commandBoxPlaceholder" styleClass="pane-with-border" VBox.vgrow="NEVER">
Expand All @@ -228,12 +228,12 @@
</padding>
</StackPane>

<StackPane fx:id="resultDisplayPlaceholder" maxHeight="100" minHeight="100" prefHeight="100" styleClass="pane-with-border" VBox.vgrow="NEVER">
<StackPane fx:id="resultDisplayPlaceholder" maxHeight="150" minHeight="150" prefHeight="150" styleClass="pane-with-border">
<padding>
<Insets bottom="5" left="10" right="10" top="5" />
</padding>
</StackPane>
<HBox>
<HBox VBox.vgrow="ALWAYS">
<VBox fx:id="personList" minWidth="340" prefWidth="450"
styleClass="pane-with-border" VBox.vgrow="ALWAYS">
<padding>
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/view/PersonListCard.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<?import javafx.scene.layout.RowConstraints?>
<?import javafx.scene.layout.VBox?>

<HBox id="cardPane" fx:id="cardPane" xmlns="http://javafx.com/javafx/21" xmlns:fx="http://javafx.com/fxml/1">
<HBox id="cardPane" fx:id="cardPane" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1">
<GridPane HBox.hgrow="ALWAYS">
<columnConstraints>
<ColumnConstraints hgrow="SOMETIMES" minWidth="10" prefWidth="150" />
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/view/ResultDisplay.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

<StackPane fx:id="placeHolder" styleClass="pane-with-border" xmlns="http://javafx.com/javafx/17"
xmlns:fx="http://javafx.com/fxml/1">
<TextArea fx:id="resultDisplay" editable="false" styleClass="result-display"/>
<TextArea fx:id="resultDisplay" editable="false" wrapText="true" styleClass="result-display"/>
</StackPane>
2 changes: 1 addition & 1 deletion src/main/resources/view/RoleListCard.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<?import javafx.scene.layout.RowConstraints?>
<?import javafx.scene.layout.VBox?>

<HBox id="cardPane" fx:id="cardPane" xmlns="http://javafx.com/javafx/21" xmlns:fx="http://javafx.com/fxml/1">
<HBox id="cardPane" fx:id="cardPane" xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1">
<GridPane HBox.hgrow="ALWAYS">
<columnConstraints>
<ColumnConstraints hgrow="SOMETIMES" minWidth="10" prefWidth="150" />
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/view/RoleListPanel.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
<?import javafx.scene.layout.VBox?>

<VBox xmlns="http://javafx.com/javafx/17" xmlns:fx="http://javafx.com/fxml/1">
<ListView fx:id="roleListView" VBox.vgrow="ALWAYS" />
<ListView fx:id="roleListView" />
</VBox>

0 comments on commit 99eca17

Please sign in to comment.