Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UserGuide for filter #93

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Update UserGuide for filter #93

merged 4 commits into from
Mar 17, 2024

Conversation

iynixil
Copy link
Collaborator

@iynixil iynixil commented Mar 17, 2024

Part of #90

@iynixil iynixil added the type.Documentation Improvements or additions to documentation label Mar 17, 2024
@iynixil iynixil added this to the v1.2 milestone Mar 17, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (7597490) to head (002fc1a).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #93   +/-   ##
=========================================
  Coverage     79.68%   79.68%           
  Complexity      579      579           
=========================================
  Files            90       90           
  Lines          1738     1738           
  Branches        179      179           
=========================================
  Hits           1385     1385           
  Misses          320      320           
  Partials         33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tsulim
tsulim reviewed Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@tsulim tsulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, I think you might have missed out editing the portion under Command Summary

@JerryWang0000 JerryWang0000 linked an issue Mar 17, 2024 that may be closed by this pull request
Update pictures in UserGuide #92
Closed
@JerryWang0000 JerryWang0000 removed a link to an issue Mar 17, 2024
Update pictures in UserGuide #92
Closed
@iynixil
Copy link
Collaborator Author

iynixil commented Mar 17, 2024

fixed!

tsulim
tsulim approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@tsulim tsulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tsulim tsulim merged commit f300e49 into AY2324S2-CS2103-F08-3:master Mar 17, 2024
5 checks passed
@iynixil iynixil linked an issue Mar 18, 2024 that may be closed by this pull request
Update Documentation for Filter #90
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsulim tsulim tsulim approved these changes

Assignees

@iynixil iynixil

Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Update Documentation for Filter
2 participants
@iynixil @tsulim