Update Sort to include attribute Faculty #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
============================================
+ Coverage 79.57% 79.68% +0.11%
- Complexity 574 579 +5
============================================
Files 89 90 +1
Lines 1733 1738 +5
Branches 178 179 +1
============================================
+ Hits 1379 1385 +6
+ Misses 321 320 -1
Partials 33 33 ☔ View full report in Codecov by Sentry. |
7 tasks
whitesnowx
added
type.Task
| @@ -43,6 +44,7 @@ public void equals() { | |||
| assertFalse(nameSortCommand.equals(new SortCommand(MODULE_COMPARATOR))); | |||
| assertFalse(nameSortCommand.equals(new SortCommand(VENUE_COMPARATOR))); | |||
| assertFalse(nameSortCommand.equals(new SortCommand(PHONE_COMPARATOR))); | |||
| assertFalse(nameSortCommand.equals(new SortCommand(FACULTY_COMPARATOR))); | |||
There was a problem hiding this comment.
it would be better to arrage in alphabetic order
There was a problem hiding this comment.
I think better to follow person's order, for readability? Also following how edit and add did their ordering.
Update: currently changed to person's order
| assertParseSuccess(parser, "" + PREFIX_VENUE, new SortCommand(VENUE_COMPARATOR)); | ||
| assertParseSuccess(parser, "" + PREFIX_FACULTY, new SortCommand(FACULTY_COMPARATOR)); |
There was a problem hiding this comment.
it would be better to arrange in alphabetic order
2 tasks
iynixil
approved these changes
Mar 17, 2024
Comment on lines
109
to
112
| public static List<Person> getTypicalPersons() { | ||
| return new ArrayList<>(Arrays.asList(ALICE, BENSON, CARL, CLARA, DANIEL, ELLE, FIONA, GEORGE, KAFKA, NATASHA)); | ||
| return new ArrayList<>(Arrays.asList(ALICE, BENSON, CARL, CLARA, DANIEL, ELLE, FIONA, GEORGE, KAFKA, NATASHA, | ||
| LEONARDO, MICHAEL)); | ||
| } |
There was a problem hiding this comment.
ordering here is not in alphabetical order, next time we can edit this too
Comment on lines
+69
to
+81
| public static final Person KAFKA = new PersonBuilder().withName("Kafka Apache").withPhone("9452413") | ||
| .withEmail("[email protected]").withModule("CS2102").withFaculty("Business") | ||
| .withVenue("pteruges avenue").withTags("classmate").withAvailabilities("FRIDAY").build(); | ||
| public static final Person NATASHA = new PersonBuilder().withName("Natasha Harrower").withPhone("8019394") | ||
| .withEmail("[email protected]").withModule("CS2102") | ||
| .withFaculty("Computing").withVenue("underworld avenue") | ||
| .withTags("classmate").withAvailabilities("FRIDAY").build(); | ||
| public static final Person LEONARDO = new PersonBuilder().withName("Leonardo DiCaprio").withPhone("88472234") | ||
| .withEmail("[email protected]").withModule("TS2237") | ||
| .withFaculty("Arts and Social Sciences").withVenue("LT13").build(); | ||
| public static final Person MICHAEL = new PersonBuilder().withName("Michael Jackson").withPhone("92347123") | ||
| .withEmail("[email protected]").withModule("MUA1163") | ||
| .withFaculty("Music").withVenue("YSTCM-SR9").build(); |
There was a problem hiding this comment.
good move to add our manually added testing data here, forgot about CLARA though, next time can edit!
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #83