Update NFR and Glossary in DeveloperGuide.md #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add content to NFR and Glossary in Appendix: Requirements.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
whitesnowx
reviewed
Mar 6, 2024
whitesnowx
changed the title
This was
linked to
issues
Mar 6, 2024
…ate-DeveloperGuide * 'master' of https://github.com/JerryWang0000/tp: Update file names to follow format Update aboutus page with my details and photo Update typos Change use case for filter and typo in sort aboutus update file name changed names to match github names update aboutus info to name match lowercase requirements Updated use cases Update AboutUs for Jerry Wang
tsulim
reviewed
Mar 6, 2024
Comment on lines
+405
to
406
| 9. A user without much experience in admin commands should be able to handle the usage in rather short time. | ||
| *{More to be added}* |
There was a problem hiding this comment.
I think you might have missed out an empty line between this two lines. Currently the two lines have been combined into 1 line in the preview.
| *{More to be added}* | ||
|
|
||
| ### Glossary | ||
|
|
||
| * **Mainstream OS**: Windows, Linux, Unix, MacOS | ||
| * **Private contact detail**: A contact detail that is not meant to be shared with others | ||
| * **Users' Information**: Same as above |
There was a problem hiding this comment.
Perhaps you could specify the possible information just like for Mainstream OS where the OS are being listed down?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add content to NFR and Glossary in Appendix: Requirements. As for the Glossary part, I don't really find much stuff worthy of recording, at least for now.