-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG on the implementation of Meeting #249
Update DG on the implementation of Meeting #249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage 78.55% 78.55%
Complexity 846 846
=========================================
Files 121 121
Lines 2583 2583
Branches 262 262
=========================================
Hits 2029 2029
Misses 498 498
Partials 56 56 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! some suggestions and nits
Been amended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see that the delete meeting
UML has been changed to specific example, will add meeting
UML and steps also be changed?
otherwise, lgtm.
some subheadings got changed, not sure if intentional?
The steps are pretty much the same, in fact they are elaborating the general idea of each step as the content of the arguments are not important at that point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but I have spotted some inconsistency in the changes made.
Added to use cases for add meeting and delete meeting as well.